Replace try! with ?.#36041
Conversation
|
r? @nrc (rust_highfive has picked a reviewer for you, use r? to override) |
|
lgtm, but just checking with @rust-lang/compiler that they approve |
|
cc @jonathandturner Does this change anything |
|
This is all internal stuff, linbsyntax is touched in #36037 |
|
@nrc I was asking mostly because of a potential move of libsyntax to the error code system used in rustc. |
|
I can move changes (if there are any) that would impact syntex to #36037, easily enough and then get this merged. |
|
None of these affect syntex. |
|
@bors: r+ |
|
📌 Commit 26296c4 has been approved by |
|
👍 |
|
☔ The latest upstream changes (presumably #35718) made this pull request unmergeable. Please resolve the merge conflicts. |
|
I assume this needs to be approved again @nrc? |
|
☔ The latest upstream changes (presumably #36227) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@ahmedcharles yes, and unfortunately it needs another rebase now. When you push new commits, it is a good idea to ping the reviewer in a comment since GitHub does not send notifications about new commits (thus why I missed this). |
It does if you check the "Pull Request pushes" box at https://github.com/settings/notifications:
|
|
@dtolnay - if we checked that, for the amount of PRs we review, we'd likely swamp our inbox and still not see it, sadly |
|
@nrc Probably ready for another try. |
|
@bors: r+ |
|
📌 Commit a51dc66 has been approved by |
|
⌛ Testing commit a51dc66 with merge 97d8c0c... |
|
💔 Test failed - auto-win-msvc-64-cargotest |
|
@bors: retry On Fri, Sep 9, 2016 at 2:04 PM, bors notifications@github.com wrote:
|
|
💔 Test failed - auto-win-msvc-64-cargotest |
|
Seems like an intermittent failure @alexcrichton @nrc ? |
There was a problem hiding this comment.
This file does not look like it's actually part of this PR.
|
The merge conflict issue is fixed. @nrc. |
|
@bors: r+ |
|
📌 Commit 694d601 has been approved by |
|
⌛ Testing commit 694d601 with merge 389abeb... |
|
💔 Test failed - auto-win-msvc-64-opt-rustbuild |
|
@bors: retry On Tue, Sep 13, 2016 at 6:43 PM, bors notifications@github.com wrote:
|
|
⌛ Testing commit 694d601 with merge 739d571... |
No description provided.